Some Qt installations do not have `qmake.exe` but `qmake.bat` instead. This commit adds a check for `qmake.bat` in the Qt installation directory. Fixes: VSCODEEXT-117 Change-Id: I2d4aa5fdda216739be16bc3a95867496d2817561 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Pick-to: 1.1.0 Change-Id: I7b818025dd1684620f855dbd14b21d4c50481e23 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
In the previous implementation, the extensions were using only one way to communicate with each other, which was getting a notification when a config value was set or changed. This was problematic on startup because there was no order in which the extensions were activated and when messages were handled. b5bf26ac084823758be18453bb61579fefceb57c partially fixed this issue by adding a way to wait for `qt-cpp` to be ready, but it was still not enough. The extension should read config values when they are ready, not when messages are sent from other extensions. Remove the `lazy` initialization parameter in `Project` classes. Instead of using that parameter, we remove the firing event from `addProject()` and only fire when the project is added after startup. This way, we don't need the `lazy` parameter anymore. Since `processMessage()` is not used during startup, this commit also fixes QTBUG-131702 on the extension side. qt-lib: This commit changes `QtWorkspaceConfigMessage` and removes values in it. `QtWorkspaceConfigMessage` is now used only to notify that a value or values were set. The value `CoreApi` can be accessed by `getValue` and `setValue`. * Update the `CoreApi` interface * Add `setValue` * Rename `update` to `notify` * Remove `get<T>()` from `QtWorkspaceConfigMessage` qt-core: * Remove the internal checking mechanism to understand if a value was set or changed. Instead, just store values. qt-cpp: * Update `processMessage()` for the new usage. * Initialize config values explicitly during startup. qt-qml: * Update `processMessage()` for the new usage. * Separate starting `qmlls` from the constructor. It should be started when the conditions are met. * Get config values and update parameters inside `onProjectAdded()` Task-number: QTBUG-131702 Change-Id: If9831ea1257d123f777e6ae2afb92f33942dd3da Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Change-Id: Iab1c9f545d8b10ad13127a3a77545a3f4f475597 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
During the startup,`qt-qml` and `qt-ui` should wait until `qt-cpp`` sets the initial configuration values. Otherwise, qt-qml qt-ui may not be able to access the correct configuration values. Change-Id: I974a0e5e7e9cb541ea4a382ac85c303b6b59646f Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Change-Id: Ic95878fd83d6861b2d0d04a118a23a6e7278342d Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Since event handlers are not disposed properly, they are still active when the project is closed. This can cause those handlers to be called after the project is closed, which can lead to errors. * Dispose project managers inside `Deactivate()` Change-Id: Idd7b8548f7c16c41c0e4fd7052fa7ae988678bc4 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
When only the value is checked whether it is undefined or not, it doesn't give us the correct result because the value either can be set to undefined or not set at all. We get undefined in both cases. We should check the key is set in the message first instead. Change-Id: Ic4c17e96c3975adcbc49eb82e7b1999d3dcec851 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
https: //www.typescriptlang.org/tsconfig/#incremental Change-Id: I750398a09178e02c3b3c73bf8e8fc7654dab03d4 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
On some platforms, Designer is not located in any of the qtpaths keys directly. We also need to check `tools/qttools/bin` for Designer. Change-Id: I0a49868262019654d6fd8aebbc9be76fb9f3da20 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>